[Linux-Xtensa] Re: [patch 09/12] xtensa: allow platform and variant to initialize own irq chips

Chris Zankel chris at zankel.net
Thu Apr 23 10:20:40 PDT 2009


Hi Daniel,

Daniel Glöckner wrote:
> On 04/23/2009 09:19 AM, Chris Zankel wrote:
>>> +#ifndef VARIANT_NR_IRQS
>>> +# define VARIANT_NR_IRQS 0
>>> +#endif
> 
> Where can a variant define VARIANT_NR_IRQS if not inside a new header?
> Do you prefer it being defined in core.h, tie.h, or tie-asm.h?

[...]

> Another possibility would be to select VARIANT_IRQ_SWITCH (or a dedicated new
> Kconfig option) in all SoCs that need additional IRQs.

Wasn't the original code before your patch just doing that?

-#ifdef CONFIG_VARIANT_IRQ_SWITCH
  #include <variant/irq.h>
-#else
+#ifndef CONFIG_VARIANT_IRQ_SWITCH

variant/irq.h was included but only if VARIANT_IRQ_SWITCH was defined.

Thanks,
-Chris


More information about the linux-xtensa mailing list