[Linux-Xtensa] Audio Driver - applied your git patch, I'm looking into building your config on an LX200...

Piet Delaney pdelaney at tensilica.com
Tue Sep 14 22:28:38 PDT 2010


Hi Truby:

I Applied your patch with 'git apply':
----------------------------------------------------------------------------------
[piet at pdelaney_fc9 xtensa-2.6.29-smp]$ git apply ../git_patch_chipsbank_10_09_08
../git_patch_chipsbank_10_09_08:18: trailing whitespace.
          This is the driver of the Audio dsp (decoders and encoders )
../git_patch_chipsbank_10_09_08:62: trailing whitespace.
  @Brief:  driver for cbm60xx audio dsp module
../git_patch_chipsbank_10_09_08:91: trailing whitespace.
/**
../git_patch_chipsbank_10_09_08:107: trailing whitespace.
     if ((id != chan->index) || (fmt == chan->format))
../git_patch_chipsbank_10_09_08:109: trailing whitespace.
	    return -1;
warning: squelched 696 whitespace errors
warning: 701 lines add whitespace errors.
[piet at pdelaney_fc9 xtensa-2.6.29-smp]$
-------------------------------------------------------------------------------------
I didn't expect any errors to be reported.

My current 'git status' is:
.......................................................................................
$ git status
# On branch IO_PORTS_Piggy_Back_On_Coprocessor_Infrastructure_Proposal
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#	modified:   drivers/media/Kconfig
#	modified:   drivers/media/Makefile
#	new file:   drivers/media/audio/Kconfig
#	new file:   drivers/media/audio/Makefile
#	new file:   drivers/media/audio/audio_dsp.c
#	new file:   drivers/media/audio/audio_dsp.h
#	new file:   drivers/media/audio/buffer.c
#	new file:   drivers/media/audio/buffer.h
#	new file:   drivers/media/audio/cbm60xx_dsp.c
#	new file:   drivers/media/audio/cbm60xx_dsp.h
#	new file:   drivers/media/audio/mailbox.c
#	new file:   drivers/media/audio/mailbox.h
#	new file:   drivers/media/audio/readme
....................................................................................

I made a copy of 2.6.29-smp at linux-xtensa.org and called it "xtensa-2.6.29-smp-chipsbank.git".
I made you the owner with group access by folks in the chipsbank group.

As you can see the files are not accessible vie the git web access:

	http://git.linux-xtensa.org/cgi-bin/git.cgi

it's only accessible by you and other members of the 'chipsbank'
group. I added Marc and myself as members of the group.

This approach allows our customers to keep their code un-published
until they are ready to push their changes to kernel.org.

Would it be ok for me to push your patch that I just applied there
so we are all on the same page? Feel free to push it your self;
which would really be a bit better. I recommend we make a branch
off of the proposed "IO_PORTS_Piggy_Back_On_Coprocessor_Infrastructure_Proposal"
branch.

In the mean time I'll try configuring it in and starting builds to put
together a bitstream for the LX200 with your cores on it.

So far it appears you git patch includes only the code run on the CB570TMMU.
Did I miss the code intended to run on the DC_330HiFi core?

The readme at the end of the git patch mentions dsp code and an application.
The dsp code is suppose to be in a 'dsp_code' dir. Looks like your using
the same xa_mp3_dec.a library that we use in the HiFi-2 SMP LX200 board:
	
	http://wiki.linux-xtensa.org/index.php/Mplayer_Hifi_2_Codec_Development_Board

If ya go about 3/4 down the page to the section on compiling the Mplayer Plugins:

	 Compiling the Mplayer Plugins and linking them with MPEG-1 Audio Layer 3 (MP3) and MPEG-4 AAC Codecs

you will see how we mount the codes's in an NFS mounted directory on the target
and then let the Makefile patch Mplayer with the codec library plugins.

In your case the Linux system isn't running with the HiFI-2 TIE instructions
and we have to do everything on our workstations. Do you have a makefile
to easily link the coded librarys to your test program? I suppose your
saying I should just make a trivial Makefile for your application and
have it link directly to the codec library's. If you have a tar ball
with the audio/test src and Makefile it would be good to send it
once I've got you cores running on an LX200. Looks like I'll have
a handful already with building the bitstream and messing around with
the KERNELOFFSET and LOAD_MEMORY_ADDRESS.

-piet
	



More information about the linux-xtensa mailing list