[Linux-Xtensa] Re: [PATCH] xtensa: remove the second argument of __bio_kmap_atomic()

czankel chris at zankel.net
Mon Jul 8 01:32:03 PDT 2013

Hi Zhao, Geert,

Looks that the iss driver for Xtensa is the only one using __bio_k{un}map_atomic right now?

Just asking because the patch includes a change to a 'generic' file.


diff --git a/include/linux/bio.h b/include/linux/bio.h
index ef24466..ec48bac 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -97,11 +97,11 @@ static inline void *bio_data(struct bio *bio)
   * permanent PIO fall back, user is probably better off disabling highmem
   * I/O completely on that queue (see ide-dma for example)
-#define __bio_kmap_atomic(bio, idx, kmtype)				\
+#define __bio_kmap_atomic(bio, idx)				\
  	(kmap_atomic(bio_iovec_idx((bio), (idx))->bv_page) +	\
  		bio_iovec_idx((bio), (idx))->bv_offset)
-#define __bio_kunmap_atomic(addr, kmtype) kunmap_atomic(addr)
+#define __bio_kunmap_atomic(addr) kunmap_atomic(addr)

On 7/8/13 1:13 AM, Geert Uytterhoeven wrote:
> On Mon, Jul 8, 2013 at 9:22 AM, Zhao Hongjiang <zhaohongjiang at huawei.com> wrote:
>> kmap_atomic allows only one argument now, just remove the unused 'kmtype'.
>> Signed-off-by: Zhao Hongjiang <zhaohongjiang at huawei.com>
> Acked-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Gr{oetje,eeting}s,
>                          Geert
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

More information about the linux-xtensa mailing list